Quantcast
Channel: User Schwern - Stack Overflow
Viewing all articles
Browse latest Browse all 581

Comment by Schwern on Strategies for spotting changes inside moved or renamed files in git

$
0
0
I would add a third argument to doing the rename and modification separately: simplicity and ease of review. Since class names and the like are often tied to file names, renaming a file means renaming a class which can have a broad impact on the code. A major refactoring like that plus a bug fix/feature change is a lot to review. Separate them into two PRs and it will go better. if you can't get devs to follow that, that's a process issue for your team.

Viewing all articles
Browse latest Browse all 581

Trending Articles